From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50277 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLBa8-0001Sf-Py for qemu-devel@nongnu.org; Wed, 24 Nov 2010 04:24:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLBa7-0007jz-Pi for qemu-devel@nongnu.org; Wed, 24 Nov 2010 04:24:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLBa7-0007js-Iy for qemu-devel@nongnu.org; Wed, 24 Nov 2010 04:24:03 -0500 Date: Wed, 24 Nov 2010 11:23:44 +0200 From: "Michael S. Tsirkin" Message-ID: <20101124092344.GA22221@redhat.com> References: <4CE49053.3000608@cn.fujitsu.com> <4CE7313B.1070103@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CE7313B.1070103@codemonkey.ws> Subject: [Qemu-devel] Re: [PATCH] stop the iteration when too many pages is transferred List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel , Wen Congyang On Fri, Nov 19, 2010 at 08:23:55PM -0600, Anthony Liguori wrote: > On 11/17/2010 08:32 PM, Wen Congyang wrote: > > When the total sent page size is larger than max_factor > > times of the size of guest OS's memory, stop the > > iteration. > > The default value of max_factor is 3. > > > > This is similar to XEN. > > > > > > Signed-off-by: Wen Congyang > > > > I'm strongly opposed to doing this. I think Xen gets this totally wrong. Additionally, please don't just change the behaviour of existing commands. Make any new behaviour opt-in. -- MST