From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38226 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLJYA-0001xA-T7
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 12:54:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PLJSz-00035J-E7
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 12:51:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48549)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PLJSz-00034i-7C
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 12:49:13 -0500
Date: Wed, 24 Nov 2010 15:48:57 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101124154857.10657aa1@doriath>
In-Reply-To: <4CEC6A56.8080309@cn.fujitsu.com>
References: <4CEB5406.3060300@cn.fujitsu.com> <20101123104348.5d44e89e@doriath>
	<20101123113159.4aab053a@doriath> <4CEC6A56.8080309@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: armbru@redhat.com, qemu-devel <qemu-devel@nongnu.org>

On Wed, 24 Nov 2010 09:28:54 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> At 2010=E5=B9=B411=E6=9C=8823=E6=97=A5 21:31, Luiz Capitulino Write:
> > On Tue, 23 Nov 2010 10:43:48 -0200
> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
> >=20
> >> On Tue, 23 Nov 2010 13:41:26 +0800
> >> Wen Congyang <wency@cn.fujitsu.com> wrote:
> >>
> >>> The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> >>> When we set migrate speed by json, qemu will be core dumped.
> >>>
> >>> Signed-off-by: Wen Congyang
> >>
> >> Nice catch.
> >>
> >> Was caused by 07de3e60b05 and hence affects master only. Could you ple=
ase
> >> mention that in the commit log? Also, your email address is missing
> >> in the signed-off-by line.
> >=20
> > There's another problem there: we used to accept a json number but now =
we
> > accept only a json integer.
>=20
> Do you mean the parameter passed to migrate_set_speed by json should be
> float or integer?

We used to accept both until the aforementioned commit.

> But in the function do_migrate_set_speed(), we only accept a integer.

Yes, that's a behavior change and I'd like to check with Markus that
he's aware of it. In any case, I'll apply your fix as soon as you send
me a new version with the changes I asked.

>=20
> >=20
> > Markus, are you aware of this change?
> >=20
> >>
> >>>
> >>> ---
> >>>  qmp-commands.hx |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/qmp-commands.hx b/qmp-commands.hx
> >>> index 793cf1c..16bdb08 100644
> >>> --- a/qmp-commands.hx
> >>> +++ b/qmp-commands.hx
> >>> @@ -495,7 +495,7 @@ EQMP
> >>> =20
> >>>      {
> >>>          .name       =3D "migrate_set_speed",
> >>> -        .args_type  =3D "value:f",
> >>> +        .args_type  =3D "value:o",
> >>>          .params     =3D "value",
> >>>          .help       =3D "set maximum speed (in bytes) for migrations=
",
> >>>          .user_print =3D monitor_user_noop,
> >>
> >=20
> >=20
>=20