From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43236 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLIjo-0003y1-1N for qemu-devel@nongnu.org; Wed, 24 Nov 2010 12:02:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLIYp-0003a7-0h for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:53:33 -0500 Received: from verein.lst.de ([213.95.11.210]:39801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLIYo-0003Zq-L9 for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:51:10 -0500 Date: Wed, 24 Nov 2010 17:51:07 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 02/15] scsi: Return SAM status codes Message-ID: <20101124165107.GD31124@lst.de> References: <1290597370-21365-1-git-send-email-hare@suse.de> <1290597370-21365-3-git-send-email-hare@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290597370-21365-3-git-send-email-hare@suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com On Wed, Nov 24, 2010 at 12:15:57PM +0100, Hannes Reinecke wrote: > Traditionally, the linux stack is using SCSI status codes > which are shifted by one as compared to those defined in SAM. > A SCSI emulation should naturally return the SAM defined codes, > not the linux ones. > So to avoid any confusion this patch modifies the existing > definitions to match those found in SAM and removes any > (now obsolete) byte-shift from the returned status codes. Looks good.