From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35169 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLIjW-0006ER-Ng for qemu-devel@nongnu.org; Wed, 24 Nov 2010 12:02:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLIaU-000480-Es for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:55:11 -0500 Received: from verein.lst.de ([213.95.11.210]:39810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLIaU-00047i-57 for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:52:54 -0500 Date: Wed, 24 Nov 2010 17:52:50 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback Message-ID: <20101124165250.GE31124@lst.de> References: <1290597370-21365-1-git-send-email-hare@suse.de> <1290597370-21365-14-git-send-email-hare@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290597370-21365-14-git-send-email-hare@suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com On Wed, Nov 24, 2010 at 12:16:08PM +0100, Hannes Reinecke wrote: > Add callback to create a request with a predefined iovec. > This is required for drivers which can use the iovec > of a command directly. What happend to my comment that the iov and non-iov case should share code? Also what happened to the other comment about not naming the method implementation different from the method name.