From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52878 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLbtt-0003yy-VG
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:30:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PLbts-0002uH-Dq
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:30:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PLbts-0002u8-5O
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:30:12 -0500
Date: Thu, 25 Nov 2010 11:29:33 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101125112933.4cee22a4@doriath>
In-Reply-To: <4CEDB67D.9070904@cn.fujitsu.com>
References: <4CEB5406.3060300@cn.fujitsu.com> <20101123104348.5d44e89e@doriath>
	<20101123113159.4aab053a@doriath> <4CEC6A56.8080309@cn.fujitsu.com>
	<20101124154857.10657aa1@doriath> <4CEDB67D.9070904@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] correct migrate_set_speed's args_type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: armbru@redhat.com, qemu-devel <qemu-devel@nongnu.org>

On Thu, 25 Nov 2010 09:06:05 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> When we set migrate speed by json, qemu will be core dumped.
> 
> This bug was caused by 07de3e60b05 and hence affects master only.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

Applied, thanks.

> 
> ---
>  qmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 793cf1c..16bdb08 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -495,7 +495,7 @@ EQMP
>  
>      {
>          .name       = "migrate_set_speed",
> -        .args_type  = "value:f",
> +        .args_type  = "value:o",
>          .params     = "value",
>          .help       = "set maximum speed (in bytes) for migrations",
>          .user_print = monitor_user_noop,
> -- 1.7.1 
>