From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46425 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLbJO-0004Bn-If
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:52:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbJN-00039W-Le
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:52:30 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:34629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbJN-00039P-Ba
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:52:29 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation
Date: Thu, 25 Nov 2010 12:52:19 +0000
References: <1290522889-27559-1-git-send-email-agraf@suse.de>
	<201011251245.18949.paul@codesourcery.com>
	<48421299-B6E4-43F9-BF02-A15B197F1A3D@suse.de>
In-Reply-To: <48421299-B6E4-43F9-BF02-A15B197F1A3D@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011251252.19486.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, Alexander Graf <agraf@suse.de>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, tj@kernel.org, Sebastian Herbszt <herbszt@gmx.de>, Roland Elek <elek.roland@gmail.com>

> > less than half of the targets are big-endian. If it's broken on
> > big-endian there should be a comment somewhere documenting this, so we
> > know to fix it.
> 
> Well, it's stated in the cover letter and the same is true for almost every
> PCI device in qemu we have today. So what would you prefer? Add the device
> in every default config? Have a pci combination .mak that we can include
> on all pci capable machines so we don't end up patching 50 files for every
> device?

Yes, something like that.

Paul