From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58857 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLbmf-0006ko-1y
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:22:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbmb-0000lo-Ia
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:22:44 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:35424)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbmb-0000lI-An
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 08:22:41 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Make SCSI HBA configurable
Date: Thu, 25 Nov 2010 13:22:30 +0000
References: <20101122101536.41288F90AF@ochil.suse.de>
	<201011251059.31561.paul@codesourcery.com>
	<A75C3595-D6D2-4CD7-853B-CBD2294E3131@suse.de>
In-Reply-To: <A75C3595-D6D2-4CD7-853B-CBD2294E3131@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011251322.31081.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: stefanha@gmail.com, kraxel@redhat.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, Hannes Reinecke <hare@suse.de>

> On 25.11.2010, at 11:59, Paul Brook wrote:
> >> This patch introduces configuration variables
> >> CONFIG_SCSI_LSI
> >> CONFIG_SCSI_MEGASAS
> >> and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP.
> >> With this the available SCSI HBAs can be configured for each
> >> target configuration instead of compiling it in for everyone.
> > 
> > No. These are both PCI devices, I see no particularly good reason to make
> > them optional. At minimum they should be enabled by default on all
> > configs.
> > 
> > The ESP controller is different because it is't a general purpose device,
> > and only makes sense on certain systems.
> 
> RH needs to compile out as much as they can from the code base, because
> they state that they support everything that's compiled in. So making as
> much as possible optional is good. And I don't see why we should limit
> ourselves here.

My second point (should be enabled by default) still applies.  Your patch 
removes the lsi controller from the default arm-softmmu config, which is 
definitely wrong.

Paul