From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60176 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLyNO-0002PG-95 for qemu-devel@nongnu.org; Fri, 26 Nov 2010 08:30:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLyNN-00072C-Bl for qemu-devel@nongnu.org; Fri, 26 Nov 2010 08:30:10 -0500 Received: from verein.lst.de ([213.95.11.210]:54821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLyNN-00071w-2i for qemu-devel@nongnu.org; Fri, 26 Nov 2010 08:30:09 -0500 Date: Fri, 26 Nov 2010 14:29:59 +0100 From: Christoph Hellwig Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk Message-ID: <20101126132959.GA9040@lst.de> References: <20101124165835.GF31124@lst.de> <4CED5700.9070204@goop.org> <20101124184405.GA2406@lst.de> <4CEF9407.80706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CEF9407.80706@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jeremy Fitzhardinge , xen-devel@lists.xensource.com, Christoph Hellwig , Stefano Stabellini , qemu-devel@nongnu.org On Fri, Nov 26, 2010 at 12:03:35PM +0100, Kevin Wolf wrote: > I don't think the synchronous flushes even do what they're supposed to > do. Shouldn't ioreq->postsync do the flush after the request has > completed instead of doing it as soon as it has been submitted? Indeed, that's yet another bug in the implementation.