* [Qemu-devel] [PATCH] vhost: Fix address calculation in vhost_dev_sync_region()
@ 2010-11-27 14:05 Jason Wang
2010-11-28 8:10 ` [Qemu-devel] " Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2010-11-27 14:05 UTC (permalink / raw)
To: qemu-devel, mst
We still need advance address even we find there's no dirty pages in
current chunk.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/vhost.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index 8586f66..6082da2 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -37,6 +37,7 @@ static void vhost_dev_sync_region(struct vhost_dev *dev,
/* We first check with non-atomic: much cheaper,
* and we expect non-dirty to be the common case. */
if (!*from) {
+ addr += VHOST_LOG_CHUNK;
continue;
}
/* Data must be read atomically. We don't really
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] vhost: Fix address calculation in vhost_dev_sync_region()
2010-11-27 14:05 [Qemu-devel] [PATCH] vhost: Fix address calculation in vhost_dev_sync_region() Jason Wang
@ 2010-11-28 8:10 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-11-28 8:10 UTC (permalink / raw)
To: Jason Wang; +Cc: qemu-devel
On Sat, Nov 27, 2010 at 10:05:07PM +0800, Jason Wang wrote:
> We still need advance address even we find there's no dirty pages in
> current chunk.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/vhost.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks!
> diff --git a/hw/vhost.c b/hw/vhost.c
> index 8586f66..6082da2 100644
> --- a/hw/vhost.c
> +++ b/hw/vhost.c
> @@ -37,6 +37,7 @@ static void vhost_dev_sync_region(struct vhost_dev *dev,
> /* We first check with non-atomic: much cheaper,
> * and we expect non-dirty to be the common case. */
> if (!*from) {
> + addr += VHOST_LOG_CHUNK;
> continue;
> }
> /* Data must be read atomically. We don't really
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-28 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-27 14:05 [Qemu-devel] [PATCH] vhost: Fix address calculation in vhost_dev_sync_region() Jason Wang
2010-11-28 8:10 ` [Qemu-devel] " Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).