From: Gleb Natapov <gleb@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>,
Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio
Date: Sun, 28 Nov 2010 10:12:38 +0200 [thread overview]
Message-ID: <20101128081238.GA31855@redhat.com> (raw)
In-Reply-To: <1290670555-12575-2-git-send-email-agraf@suse.de>
On Thu, Nov 25, 2010 at 08:35:41AM +0100, Alexander Graf wrote:
> The way we're currently modeling mmio is too simplified. We assume that
> every device has the same endianness as the target CPU. In reality,
> most devices are little endian (all PCI and ISA ones I'm aware of). Some
> are big endian (special system devices) and a very little fraction is
> target native endian (fw_cfg).
>
As far as I can see fw_cfg calls cpu_to_le() on some of entries and
doesn't on others. Doesn't this makes it "mixed endian" (aka broken)?
--
Gleb.
next prev parent reply other threads:[~2010-11-28 8:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 7:35 [Qemu-devel] [PATCH 00/15] [RFC] MMIO endianness cleanup Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio Alexander Graf
2010-11-26 23:00 ` Andreas Färber
2010-11-26 23:06 ` Alexander Graf
2010-11-26 23:18 ` Peter Maydell
2010-11-26 23:47 ` Paul Brook
2010-11-27 10:05 ` Blue Swirl
2010-11-27 10:24 ` Paul Brook
2010-11-28 8:12 ` Gleb Natapov [this message]
2010-11-28 11:05 ` Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 02/15] Add endianness as io mem parameter Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 03/15] Make simple io mem handler endian aware Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 04/15] dbdma: Make little endian Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 05/15] pci-host: Delegate bswap to mmio layer Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 06/15] uninorth: Get rid of bswap Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 07/15] e1000: Make little endian Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 08/15] prep: Declare as " Alexander Graf
2010-11-26 21:58 ` Andreas Färber
2010-11-26 22:06 ` Alexander Graf
2010-11-27 0:08 ` Benjamin Herrenschmidt
2010-11-25 7:35 ` [Qemu-devel] [PATCH 09/15] versatile_pci: " Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 10/15] ppc4xx_pci: " Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 11/15] openpic: Replace explicit byte swap with endian hints Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 12/15] rtl8139: Declare as little endian Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 13/15] heathrow_pic: " Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 14/15] isa_mmio: Always use " Alexander Graf
2010-11-25 7:35 ` [Qemu-devel] [PATCH 15/15] usb_ohci: " Alexander Graf
2010-11-25 10:18 ` [Qemu-devel] [PATCH 00/15] [RFC] MMIO endianness cleanup Gerd Hoffmann
2010-11-25 10:23 ` Alexander Graf
2010-11-25 10:42 ` Gleb Natapov
2010-11-25 12:14 ` [Qemu-devel] " Paul Brook
2010-11-26 18:44 ` Blue Swirl
2010-11-26 18:49 ` Alexander Graf
2010-11-27 10:09 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-11-30 14:35 [Qemu-devel] [PATCH 00/15] [PATCH] MMIO endianness cleanup v1 Alexander Graf
2010-11-30 14:35 ` [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio Alexander Graf
2010-12-08 11:05 [Qemu-devel] [PATCH 00/15] MMIO endianness cleanup v2 Alexander Graf
2010-12-08 11:05 ` [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128081238.GA31855@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).