From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38463 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMcNP-0005mZ-5x for qemu-devel@nongnu.org; Sun, 28 Nov 2010 03:12:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMcNO-0000G0-5Y for qemu-devel@nongnu.org; Sun, 28 Nov 2010 03:12:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMcNN-0000Fl-V0 for qemu-devel@nongnu.org; Sun, 28 Nov 2010 03:12:50 -0500 Date: Sun, 28 Nov 2010 10:12:38 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH 01/15] exec: introduce endianness swapped mmio Message-ID: <20101128081238.GA31855@redhat.com> References: <1290670555-12575-1-git-send-email-agraf@suse.de> <1290670555-12575-2-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290670555-12575-2-git-send-email-agraf@suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Blue Swirl , QEMU-devel Developers , Paul Brook On Thu, Nov 25, 2010 at 08:35:41AM +0100, Alexander Graf wrote: > The way we're currently modeling mmio is too simplified. We assume that > every device has the same endianness as the target CPU. In reality, > most devices are little endian (all PCI and ISA ones I'm aware of). Some > are big endian (special system devices) and a very little fraction is > target native endian (fw_cfg). > As far as I can see fw_cfg calls cpu_to_le() on some of entries and doesn't on others. Doesn't this makes it "mixed endian" (aka broken)? -- Gleb.