From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50909 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMdee-00078h-D3 for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:34:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMded-0004sR-Bp for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:34:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMded-0004sN-4n for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:34:43 -0500 Date: Sun, 28 Nov 2010 11:33:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20101128093357.GC3342@redhat.com> References: <1290665220-26478-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1290665220-26478-14-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290665220-26478-14-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Subject: [Qemu-devel] Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy(). List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, ohmura.kei@lab.ntt.co.jp, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: > Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let > event-tap capture events from dma-helpers. > > Signed-off-by: Yoshiaki Tamura Same comment as -net here: it's not clear when should a device use bdrv_aio_writev_proxy and when bdrv_aio_writev. If all devices should just use _proxy, let's just make bdrv_aio_writev DTRT instead. > --- > dma-helpers.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dma-helpers.c b/dma-helpers.c > index 712ed89..8ab2c26 100644 > --- a/dma-helpers.c > +++ b/dma-helpers.c > @@ -117,8 +117,8 @@ static void dma_bdrv_cb(void *opaque, int ret) > } > > if (dbs->is_write) { > - dbs->acb = bdrv_aio_writev(dbs->bs, dbs->sector_num, &dbs->iov, > - dbs->iov.size / 512, dma_bdrv_cb, dbs); > + dbs->acb = bdrv_aio_writev_proxy(dbs->bs, dbs->sector_num, &dbs->iov, > + dbs->iov.size / 512, dma_bdrv_cb, dbs); > } else { > dbs->acb = bdrv_aio_readv(dbs->bs, dbs->sector_num, &dbs->iov, > dbs->iov.size / 512, dma_bdrv_cb, dbs); > -- > 1.7.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html