From: Sanchit Garg <sancgarg@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Convert fprintf() to error_request(): virtio-9p
Date: Tue, 30 Nov 2010 15:22:48 +0530 [thread overview]
Message-ID: <20101130095248.8514.75180.stgit@sancgarg.in.ibm.com> (raw)
Signed-off-by: Sanchit Garg <sancgarg@linux.vnet.ibm.com>
---
hw/virtio-9p.c | 21 +++++++++++----------
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 7c59988..d64d05a 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -18,6 +18,7 @@
#include "fsdev/qemu-fsdev.h"
#include "virtio-9p-debug.h"
#include "virtio-9p-xattr.h"
+#include "qemu-error.h"
int debug_9p_pdu;
@@ -388,8 +389,8 @@ v9fs_string_alloc_printf(char **strp, const char *fmt, va_list ap)
len += 1;
break;
default:
- fprintf(stderr,
- "v9fs_string_alloc_printf:Incorrect format %c", *iter);
+ error_report(
+ "v9fs_string_alloc_printf:Incorrect format %c", *iter);
return -1;
}
iter++;
@@ -3677,15 +3678,15 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf *conf)
if (!fse) {
/* We don't have a fsdev identified by fsdev_id */
- fprintf(stderr, "Virtio-9p device couldn't find fsdev with the "
- "id = %s\n", conf->fsdev_id ? conf->fsdev_id : "NULL");
+ error_report("Virtio-9p device couldn't find fsdev with the "
+ "id = %s", conf->fsdev_id ? conf->fsdev_id : "NULL");
exit(1);
}
if (!fse->path || !conf->tag) {
/* we haven't specified a mount_tag or the path */
- fprintf(stderr, "fsdev with id %s needs path "
- "and Virtio-9p device needs mount_tag arguments\n",
+ error_report("fsdev with id %s needs path "
+ "and Virtio-9p device needs mount_tag arguments",
conf->fsdev_id);
exit(1);
}
@@ -3707,19 +3708,19 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf *conf)
s->ctx.fs_sm = SM_NONE;
s->ctx.xops = none_xattr_ops;
} else {
- fprintf(stderr, "Default to security_model=none. You may want"
+ error_report("Default to security_model=none. You may want"
" enable advanced security model using "
"security option:\n\t security_model=passthrough \n\t "
- "security_model=mapped\n");
+ "security_model=mapped");
s->ctx.fs_sm = SM_NONE;
s->ctx.xops = none_xattr_ops;
}
if (lstat(fse->path, &stat)) {
- fprintf(stderr, "share path %s does not exist\n", fse->path);
+ error_report("share path %s does not exist", fse->path);
exit(1);
} else if (!S_ISDIR(stat.st_mode)) {
- fprintf(stderr, "share path %s is not a directory \n", fse->path);
+ error_report("share path %s is not a directory", fse->path);
exit(1);
}
next reply other threads:[~2010-12-01 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 9:52 Sanchit Garg [this message]
2010-12-01 9:35 ` [Qemu-devel] [PATCH] Convert fprintf() to error_request(): virtio-9p Stefan Hajnoczi
2010-12-01 18:01 ` Venkateswararao Jujjuri (JV)
2010-12-01 21:17 ` Stefan Hajnoczi
2010-12-14 17:33 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130095248.8514.75180.stgit@sancgarg.in.ibm.com \
--to=sancgarg@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).