From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56804 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNeiY-00036x-0J for qemu-devel@nongnu.org; Tue, 30 Nov 2010 23:55:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNPzu-0000rZ-0Q for qemu-devel@nongnu.org; Tue, 30 Nov 2010 08:11:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNPzt-0000qP-La for qemu-devel@nongnu.org; Tue, 30 Nov 2010 08:11:53 -0500 Date: Tue, 30 Nov 2010 10:45:40 -0200 From: Marcelo Tosatti Subject: Re: [Qemu-devel] [PATCHv2 2/6] cpus: flush all requests on each vm stop Message-ID: <20101130124540.GA480@amt.cnet> References: <732b3c1a27c2d274989328218bb5e831b28686dd.1290613959.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <732b3c1a27c2d274989328218bb5e831b28686dd.1290613959.git.mst@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com On Wed, Nov 24, 2010 at 05:52:58PM +0200, Michael S. Tsirkin wrote: > Make sure disk is in consistent state. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Jason Wang > --- > cpus.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 91a0fb1..d421a96 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -110,6 +110,8 @@ static void do_vm_stop(int reason) > cpu_disable_ticks(); > vm_running = 0; > pause_all_vcpus(); > + qemu_aio_flush(); > + bdrv_flush_all(); Can you move these after vm_state_notify? qemu-kvm stops vcpus there. > vm_state_notify(0, reason); > monitor_protocol_event(QEVENT_STOP, NULL); > }