From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45226 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNef8-0007ED-8c
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 23:51:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PNQM6-0006Ec-9O
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 08:34:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26603)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PNQM6-0006EQ-1G
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 08:34:50 -0500
Date: Tue, 30 Nov 2010 15:34:29 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2 2/6] cpus: flush all requests on each vm
	stop
Message-ID: <20101130133428.GB18301@redhat.com>
References: <cover.1290613959.git.mst@redhat.com>
	<732b3c1a27c2d274989328218bb5e831b28686dd.1290613959.git.mst@redhat.com>
	<20101130124540.GA480@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101130124540.GA480@amt.cnet>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com

On Tue, Nov 30, 2010 at 10:45:40AM -0200, Marcelo Tosatti wrote:
> On Wed, Nov 24, 2010 at 05:52:58PM +0200, Michael S. Tsirkin wrote:
> > Make sure disk is in consistent state.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Tested-by: Jason Wang <jasowang@redhat.com>
> > ---
> >  cpus.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/cpus.c b/cpus.c
> > index 91a0fb1..d421a96 100644
> > --- a/cpus.c
> > +++ b/cpus.c
> > @@ -110,6 +110,8 @@ static void do_vm_stop(int reason)
> >          cpu_disable_ticks();
> >          vm_running = 0;
> >          pause_all_vcpus();
> > +        qemu_aio_flush();
> > +        bdrv_flush_all();
> 
> Can you move these after vm_state_notify? qemu-kvm stops vcpus there.
> 
> >          vm_state_notify(0, reason);
> >          monitor_protocol_event(QEVENT_STOP, NULL);
> >      }

Like this:

cpus: flush all requests on each vm stop

Make sure disk is in consistent state.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Jason Wang <jasowang@redhat.com>

---

diff --git a/cpus.c b/cpus.c
index 91a0fb1..d421a96 100644
--- a/cpus.c
+++ b/cpus.c
@@ -110,6 +110,8 @@ static void do_vm_stop(int reason)
         cpu_disable_ticks();
         vm_running = 0;
         pause_all_vcpus();
+        qemu_aio_flush();
+        bdrv_flush_all();
         vm_state_notify(0, reason);
         monitor_protocol_event(QEVENT_STOP, NULL);
     }