From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57536 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNqEd-0003av-Ro
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:12:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PNqEc-0000FJ-RV
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:12:51 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:40160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PNqEc-0000Eo-If
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:12:50 -0500
Date: Wed, 1 Dec 2010 09:12:48 -0800
From: Nathan Froyd <froydnj@codesourcery.com>
Message-ID: <20101201171248.GK24280@codesourcery.com>
References: <1291116333-21354-1-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1291116333-21354-1-git-send-email-peter.maydell@linaro.org>
Subject: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan()
	functions to float*_is_quiet_nan()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On Tue, Nov 30, 2010 at 11:25:33AM +0000, Peter Maydell wrote:
> The softfloat functions float*_is_nan() were badly misnamed,
> because they return true only for quiet NaNs, not for all NaNs.
> Rename them to float*_is_quiet_nan() to more accurately reflect
> what they do.
> 
> This change was produced by:
>  perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
> (with the results manually checked.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>

Thank you for doing this.

-Nathan