From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()
Date: Wed, 1 Dec 2010 20:02:52 +0100 [thread overview]
Message-ID: <20101201190252.GC6702@laped.lan> (raw)
In-Reply-To: <20101201171248.GK24280@codesourcery.com>
On Wed, Dec 01, 2010 at 09:12:48AM -0800, Nathan Froyd wrote:
> On Tue, Nov 30, 2010 at 11:25:33AM +0000, Peter Maydell wrote:
> > The softfloat functions float*_is_nan() were badly misnamed,
> > because they return true only for quiet NaNs, not for all NaNs.
> > Rename them to float*_is_quiet_nan() to more accurately reflect
> > what they do.
> >
> > This change was produced by:
> > perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
> > (with the results manually checked.)
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>
This looks good to me too.
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Cheers
prev parent reply other threads:[~2010-12-01 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 11:25 [Qemu-devel] [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan() Peter Maydell
2010-12-01 17:12 ` [Qemu-devel] " Nathan Froyd
2010-12-01 19:02 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201190252.GC6702@laped.lan \
--to=edgar.iglesias@gmail.com \
--cc=froydnj@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).