From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: pcie aer comment
Date: Tue, 7 Dec 2010 16:22:44 +0900 [thread overview]
Message-ID: <20101207072244.GC18361@valinux.co.jp> (raw)
In-Reply-To: <20101202230235.GA12072@redhat.com>
On Fri, Dec 03, 2010 at 01:02:35AM +0200, Michael S. Tsirkin wrote:
> Also, the code has many cases that look like:
>
> if (root_cmd & PCI_ERR_ROOT_CMD_COR_EN) {
> }
> If the intent is to add some code later, pls put a TODO here.
> Otherwise please remove these or replace with comments like
> /* For correctable - nothing special needs to be done. */
Your patches of 2,3/6 introduc it. I think they can be just removed.
--
yamahata
prev parent reply other threads:[~2010-12-07 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 23:02 [Qemu-devel] pcie aer comment Michael S. Tsirkin
2010-12-07 7:22 ` Isaku Yamahata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207072244.GC18361@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).