From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54917 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPrst-0000Y7-0U
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 02:22:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PPrsr-0007Dm-V6
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 02:22:46 -0500
Received: from mail.valinux.co.jp ([210.128.90.3]:36144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PPrsr-0007Db-LA
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 02:22:45 -0500
Date: Tue, 7 Dec 2010 16:22:44 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Message-ID: <20101207072244.GC18361@valinux.co.jp>
References: <20101202230235.GA12072@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101202230235.GA12072@redhat.com>
Subject: [Qemu-devel] Re: pcie aer comment
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Dec 03, 2010 at 01:02:35AM +0200, Michael S. Tsirkin wrote:
> Also, the code has many cases that look like:
> 
>             if (root_cmd & PCI_ERR_ROOT_CMD_COR_EN) {
>             }
> If the intent is to add some code later, pls put a TODO here.
> Otherwise please remove these or replace with comments like
> 	/* For correctable - nothing special needs to be done. */

Your patches of 2,3/6 introduc it. I think they can be just removed.

-- 
yamahata