* [Qemu-devel] pcie aer comment
@ 2010-12-02 23:02 Michael S. Tsirkin
2010-12-07 7:22 ` [Qemu-devel] " Isaku Yamahata
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-12-02 23:02 UTC (permalink / raw)
To: yamahata, qemu-devel
Also, the code has many cases that look like:
if (root_cmd & PCI_ERR_ROOT_CMD_COR_EN) {
}
If the intent is to add some code later, pls put a TODO here.
Otherwise please remove these or replace with comments like
/* For correctable - nothing special needs to be done. */
--
MST
^ permalink raw reply [flat|nested] 2+ messages in thread* [Qemu-devel] Re: pcie aer comment
2010-12-02 23:02 [Qemu-devel] pcie aer comment Michael S. Tsirkin
@ 2010-12-07 7:22 ` Isaku Yamahata
0 siblings, 0 replies; 2+ messages in thread
From: Isaku Yamahata @ 2010-12-07 7:22 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
On Fri, Dec 03, 2010 at 01:02:35AM +0200, Michael S. Tsirkin wrote:
> Also, the code has many cases that look like:
>
> if (root_cmd & PCI_ERR_ROOT_CMD_COR_EN) {
> }
> If the intent is to add some code later, pls put a TODO here.
> Otherwise please remove these or replace with comments like
> /* For correctable - nothing special needs to be done. */
Your patches of 2,3/6 introduc it. I think they can be just removed.
--
yamahata
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-07 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 23:02 [Qemu-devel] pcie aer comment Michael S. Tsirkin
2010-12-07 7:22 ` [Qemu-devel] " Isaku Yamahata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).