From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, aliguori@us.ibm.com, ryanh@us.ibm.com,
aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm
Date: Wed, 8 Dec 2010 16:01:10 -0200 [thread overview]
Message-ID: <20101208160110.1b0c7c64@doriath> (raw)
Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize.
This patch adds a simple check and error message (much like the 2047 limit on
32-bit hosts) on ram_size in the control path after we determine we're
not using kvm
Upstream qemu-kvm is affected if using the -no-kvm option; this patch address
the segfault there as well.
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
NOTE: this patch was applied in the v0.12.x branch, but it seems it got
lost for master
vl.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 2dbb6db..bb9c21c 100644
--- a/vl.c
+++ b/vl.c
@@ -5792,6 +5792,12 @@ int main(int argc, char **argv, char **envp)
fprintf(stderr, "failed to initialize KVM\n");
exit(1);
}
+ } else {
+ /* without kvm enabled, we can only support 4095 MB RAM */
+ if (ram_size > (4095UL << 20)) {
+ fprintf(stderr, "qemu: without kvm support at most 4095 MB RAM can be simulated\n");
+ exit(1);
+ }
}
if (qemu_init_main_loop()) {
--
1.7.3.3.402.ga48aa
next reply other threads:[~2010-12-08 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 18:01 Luiz Capitulino [this message]
2010-12-08 18:23 ` [Qemu-devel] Re: [PATCH] Fix segfault with ram_size > 4095M without kvm Anthony Liguori
2010-12-08 18:27 ` Luiz Capitulino
2010-12-08 18:30 ` Anthony Liguori
2010-12-25 22:35 ` Aurelien Jarno
2011-01-04 15:49 ` Ryan Harper
2011-01-05 19:04 ` Ryan Harper
2011-01-06 14:48 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2010-02-23 15:13 [Qemu-devel] " Ryan Harper
2010-02-23 17:02 ` Aurelien Jarno
2010-02-23 20:30 ` Alexander Graf
2010-02-23 21:07 ` Anthony Liguori
2010-02-23 21:24 ` Aurelien Jarno
2010-02-23 22:55 ` Ryan Harper
2010-03-04 21:27 ` Aurelien Jarno
2010-03-04 21:34 ` Ryan Harper
2010-03-06 21:31 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208160110.1b0c7c64@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).