From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44683 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQdC3-0006AU-LO for qemu-devel@nongnu.org; Thu, 09 Dec 2010 04:53:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQdC2-0001Z7-Oo for qemu-devel@nongnu.org; Thu, 09 Dec 2010 04:53:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQdC2-0001Yg-IF for qemu-devel@nongnu.org; Thu, 09 Dec 2010 04:53:42 -0500 Date: Thu, 9 Dec 2010 11:53:15 +0200 From: "Michael S. Tsirkin" Message-ID: <20101209095314.GD10735@redhat.com> References: <578a2c45b25f154965c6da15a703646b2d22f57b.1291330353.git.mst@redhat.com> <4CFA43B9.1040600@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CFA43B9.1040600@redhat.com> Subject: [Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: yamahata@valinux.co.jp, qemu-devel@nongnu.org On Sat, Dec 04, 2010 at 02:35:53PM +0100, Paolo Bonzini wrote: > On 12/02/2010 11:54 PM, Michael S. Tsirkin wrote: > >+ bool assert = pcie_aer_root_does_trigger(root_cmd_set, root_status); > > Risky variable name, I think it would fail if someone includes assert.h. > > Paolo We already do, it does not seem to fail.