From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52432 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PR4zD-0007ST-Iv
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:34:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PR4z2-0004KV-F7
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:34:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PR4z2-0004KG-8D
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:34:08 -0500
Date: Fri, 10 Dec 2010 13:33:54 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101210133354.4462469f@doriath>
In-Reply-To: <m3r5dp1wot.fsf@blackfin.pond.sub.org>
References: <4CEB5406.3060300@cn.fujitsu.com> <20101123104348.5d44e89e@doriath>
	<20101123113159.4aab053a@doriath>
	<m3r5dp1wot.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On Fri, 10 Dec 2010 16:20:34 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> [Note cc: Dan, Avi]
> 
> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Tue, 23 Nov 2010 10:43:48 -0200
> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
> >
> >> On Tue, 23 Nov 2010 13:41:26 +0800
> >> Wen Congyang <wency@cn.fujitsu.com> wrote:
> >> 
> >> > The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> >> > When we set migrate speed by json, qemu will be core dumped.
> >> > 
> >> > Signed-off-by: Wen Congyang
> >> 
> >> Nice catch.
> >> 
> >> Was caused by 07de3e60b05 and hence affects master only. Could you please
> >> mention that in the commit log? Also, your email address is missing
> >> in the signed-off-by line.
> >
> > There's another problem there: we used to accept a json number but now we
> > accept only a json integer.
> >
> > Markus, are you aware of this change?
> 
> I pointed out the incompatible change in my review[*] of the offending
> patch:

Ok, I can remember now. I really think this is a small improvement and I
doubt there's any client out there depending on this.

>     This isn't backwards bug-compatible.
> 
>     Before, a client could send any number.  Any fractional part was
>     ignored.
> 
>     Now, the number must be an integer.  Other numbers are rejected.
> 
>     I don't care myself, but others have argued most forcefully for keeping
>     QMP fully backward compatible from 0.13 on, so they might object.
> 
> "Others" did not object, so this went in.  Not released yet, so it's not
> too late to object.
> 
> 
> [*] http://lists.gnu.org/archive/html/qemu-devel/2010-09/msg01905.html
>