From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35968 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PR3Vs-0001av-Ec
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:59:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PR3Vq-0008QZ-Ry
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:59:56 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:45352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PR3Vq-0008Q5-Jd
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:59:54 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 10 Dec 2010 13:59:50 +0000
References: <cover.1291987020.git.amit.shah@redhat.com>
	<38a2b7e584b2d76a6b8d116e9e291edb3b0ef50d.1291987020.git.amit.shah@redhat.com>
In-Reply-To: <38a2b7e584b2d76a6b8d116e9e291edb3b0ef50d.1291987020.git.amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201012101359.50252.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] virtio-serial: Error out if guest
	sends unexpected vq elements
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>

> Check if the guest really sent any items in the out_vq before using
> them.  Similarly, check if there is a buffer to send data in before
> writing.

Can this actually happen? If so why/how?
Why does it need a special case in this device?

If this is guest triggerable then calling abort() is wrong.

Paul