From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PR3YY-00032R-2c
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 09:02:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PR3YW-0000Vo-O1
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 09:02:41 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:45425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PR3YW-0000Vk-CD
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 09:02:40 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 10 Dec 2010 14:02:37 +0000
References: <cover.1291987020.git.amit.shah@redhat.com>
	<60d0ef242fa5d7e014a8c56f2bcc6d0cd7b6e56e.1291987020.git.amit.shah@redhat.com>
In-Reply-To: <60d0ef242fa5d7e014a8c56f2bcc6d0cd7b6e56e.1291987020.git.amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201012101402.37690.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest
	buffer to host
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>

> -        if (!discard) {
> +        if (discard) {
> +            goto next;
> +        }

> +    next:
>          virtqueue_push(vq, &elem, 0);

Please don't do this.

Paul