From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46731 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PR4SB-00013q-Dc
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:00:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PR4SA-0003UC-1T
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:00:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PR4S9-0003Tf-Ql
	for qemu-devel@nongnu.org; Fri, 10 Dec 2010 10:00:10 -0500
Date: Fri, 10 Dec 2010 20:29:57 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20101210145957.GD15015@amit-x200.redhat.com>
References: <cover.1291987020.git.amit.shah@redhat.com>
	<60d0ef242fa5d7e014a8c56f2bcc6d0cd7b6e56e.1291987020.git.amit.shah@redhat.com>
	<201012101402.37690.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201012101402.37690.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest
	buffer to host
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu list <qemu-devel@nongnu.org>

On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > -        if (!discard) {
> > +        if (discard) {
> > +            goto next;
> > +        }
> 
> > +    next:
> >          virtqueue_push(vq, &elem, 0);
> 
> Please don't do this.

Could you elaborate?

I can move the 'discard' check into the following 'for' loop, but since
the value of discard doesn't change, I moved it outside.

		Amit