qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v4 4/4] docs: Document virtio PCI -device ioeventfd=on|off
Date: Sun, 12 Dec 2010 13:24:43 +0200	[thread overview]
Message-ID: <20101212112442.GB13809@redhat.com> (raw)
In-Reply-To: <1290010769-11217-5-git-send-email-stefanha@linux.vnet.ibm.com>

On Wed, Nov 17, 2010 at 04:19:29PM +0000, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  docs/qdev-device-use.txt |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
> index f252c8e..85feda7 100644
> --- a/docs/qdev-device-use.txt
> +++ b/docs/qdev-device-use.txt
> @@ -97,15 +97,17 @@ The -device argument differs in detail for each kind of drive:
>  
>  * if=virtio
>  
> -  -device virtio-blk-pci,drive=DRIVE-ID,class=C,vectors=V
> +  -device virtio-blk-pci,drive=DRIVE-ID,class=C,vectors=V,ioeventfd=IOEVENTFD
>  
>    This lets you control PCI device class and MSI-X vectors.
>  
> +  IOEVENTFD controls whether or not ioeventfd is used for virtqueue notify.  It
> +  can be set to on (default) or off.
> +
>    As for all PCI devices, you can add bus=PCI-BUS,addr=DEVFN to
>    control the PCI device address.
>  
>  * if=pflash, if=mtd, if=sd, if=xen are not yet available with -device
> -

Intentional?

>  For USB devices, the old way is actually different:
>  
>      -usbdevice disk:format=FMT:FILENAME
> @@ -240,6 +242,9 @@ For PCI devices, you can add bus=PCI-BUS,addr=DEVFN to control the PCI
>  device address, as usual.  The old -net nic provides parameter addr
>  for that, it is silently ignored when the NIC is not a PCI device.
>  
> +For virtio-net-pci, you can control whether or not ioeventfd is used for
> +virtqueue notify by setting ioeventfd= to on (default) or off.
> +
>  -net nic accepts vectors=V for all models, but it's silently ignored
>  except for virtio-net-pci (model=virtio).  With -device, only devices
>  that support it accept it.
> -- 
> 1.7.2.3

  reply	other threads:[~2010-12-12 11:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 16:19 [Qemu-devel] [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify Stefan Hajnoczi
2010-11-17 16:19 ` [Qemu-devel] [PATCH v4 1/4] virtio-pci: Rename bugs field to flags Stefan Hajnoczi
2010-11-17 16:19 ` [Qemu-devel] [PATCH v4 2/4] virtio-pci: Use ioeventfd for virtqueue notify Stefan Hajnoczi
2010-12-12 11:22   ` [Qemu-devel] " Michael S. Tsirkin
2010-12-12 15:06     ` Stefan Hajnoczi
2010-11-17 16:19 ` [Qemu-devel] [PATCH v4 3/4] virtio-pci: Don't use ioeventfd on old kernels Stefan Hajnoczi
2010-11-17 16:19 ` [Qemu-devel] [PATCH v4 4/4] docs: Document virtio PCI -device ioeventfd=on|off Stefan Hajnoczi
2010-12-12 11:24   ` Michael S. Tsirkin [this message]
2010-12-12 15:07     ` [Qemu-devel] " Stefan Hajnoczi
2010-11-17 18:01 ` [Qemu-devel] Re: [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify Michael S. Tsirkin
2010-11-17 20:38   ` Stefan Hajnoczi
2010-11-17 20:49     ` Michael S. Tsirkin
2010-11-17 20:56       ` Stefan Hajnoczi
2010-12-01 11:53 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-01 13:59   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101212112442.GB13809@redhat.com \
    --to=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).