From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36765 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PRkDA-0001Ib-6N
	for qemu-devel@nongnu.org; Sun, 12 Dec 2010 06:35:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1PRkD5-0003Ro-0x
	for qemu-devel@nongnu.org; Sun, 12 Dec 2010 06:35:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1PRkD4-0003Qw-PC
	for qemu-devel@nongnu.org; Sun, 12 Dec 2010 06:35:22 -0500
Date: Sun, 12 Dec 2010 13:35:14 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] usb-ccid (v8)
Message-ID: <20101212113513.GA2017@playa.tlv.redhat.com>
References: <1290955607-25821-1-git-send-email-alevy@redhat.com>
	<20101207102019.GC31414@playa.tlv.redhat.com>
	<AANLkTinUJMz5aKMoXKY6wZF-BTN5-4xsoKt5xM8c80sY@mail.gmail.com>
	<4D0399DB.4090008@redhat.com>
	<AANLkTikAHvEuzuR1o8ayXiUAu8ucJHyRRLOeiYn69Q0x@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTikAHvEuzuR1o8ayXiUAu8ucJHyRRLOeiYn69Q0x@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>, qemu-devel@nongnu.org

On Sat, Dec 11, 2010 at 03:55:10PM +0000, Blue Swirl wrote:
> On Sat, Dec 11, 2010 at 3:33 PM, Hans de Goede <hdegoede@redhat.com> wr=
ote:
> > Hi,
> >
> > On 12/11/2010 10:43 AM, Blue Swirl wrote:
> >>
> >> On Tue, Dec 7, 2010 at 10:20 AM, Alon Levy<alevy@redhat.com> =A0wrot=
e:
> >>>
> >>> ping.
> >>
> >> I don't think Anthony's concerns (or mine) have been addressed.
> >>
> >
> > Could you be a bit more verbose please ?
>=20
> I'm not sure if this answer was OK for Anthony given the previous discu=
ssion:
> http://article.gmane.org/gmane.comp.emulators.qemu/85793
>=20

I'm pretty sure it's ok by anthony since he suggested the inclusion of
libcacard in qemu in the first place. (that's not a typo - I've renamed
it to avoid the double card, I'll send an updated patch merging 4/6 and
including this rename).

> About my concerns, see my previous mail about merging the shared
> library fix to 4/6 and about other stuff that does not belong to QEMU
> but which should be a separate project.
>=20
your concerns were:
 usb-ccid.c:
  endianess - I've added network to host convertions (used as guest to ho=
st).
  coding style - answer_t and bulk_in_t renamed
  hungarian style usage - gave 'excuse' (spec uses those names)
  anonymous structs usage - named
 libcaccard:
  don't build a library that qemu doesn't use: v8.1, will fold in and sen=
d v9

Am I missing anything?

Alon