From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40177 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTBYU-0002iH-BD
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 05:59:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PTBNo-0003xp-AA
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 05:48:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PTBNo-0003xZ-2E
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 05:48:24 -0500
Date: Thu, 16 Dec 2010 08:48:15 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101216084815.3ca77188@doriath>
In-Reply-To: <4D09D5EA.7070000@redhat.com>
References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath>
	<4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath>
	<m3aak7ylp6.fsf@blackfin.pond.sub.org>
	<20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3] qemu,
	qmp: convert do_inject_nmi() to QObject, QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, Markus Armbruster <armbru@redhat.com>, kvm@vger.kernel.org, Lai Jiangshan <laijs@cn.fujitsu.com>

On Thu, 16 Dec 2010 11:03:38 +0200
Avi Kivity <avi@redhat.com> wrote:

> On 12/15/2010 08:00 PM, Luiz Capitulino wrote:
> > >  >
> > >  >  Looks like a GUI feature to me,
> > >
> > >  Really?  Can't see how you can build "NMI to all CPUs" from "NMI this
> > >  CPU".  Or am I misunderstanding you?
> >
> > I guess so. Avi referred to 'nmi button on many machines', I assumed he
> > meant a virtual machine GUI, am I wrong?
> 
> I meant a real machine's GUI (it's a physical button you can press with 
> your finger, if you have thin fingers).

Ok, I didn't know that, but I had another idea: the command could accept
either a single cpu index or a list:


  { "execute": "inject-nmi", "arguments": { "cpus": 2 } }

  { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } }

This has the feature of injecting the nmi in just some cpus, although I'm
not sure this is going to be desired/useful.

If we agree on this we'll have to wait because the monitor doesn't currently
support "hybrid" arguments.