From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45104 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTBl7-0002at-Sq for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:12:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTBl1-000163-4m for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:12:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTBl0-00015w-T1 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 06:12:23 -0500 Date: Thu, 16 Dec 2010 09:12:13 -0200 From: Luiz Capitulino Message-ID: <20101216091213.214de980@doriath> In-Reply-To: <4D09EF22.4030706@redhat.com> References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> <20101216084815.3ca77188@doriath> <4D09EF22.4030706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, Markus Armbruster , kvm@vger.kernel.org, Lai Jiangshan On Thu, 16 Dec 2010 12:51:14 +0200 Avi Kivity wrote: > On 12/16/2010 12:48 PM, Luiz Capitulino wrote: > > Ok, I didn't know that, but I had another idea: the command could accept > > either a single cpu index or a list: > > > > > > { "execute": "inject-nmi", "arguments": { "cpus": 2 } } > > > > { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } } > > > > This has the feature of injecting the nmi in just some cpus, although I'm > > not sure this is going to be desired/useful. > > > > If we agree on this we'll have to wait because the monitor doesn't currently > > support "hybrid" arguments. > > I hope it never does. They're hard to support in old-school statically > typed languages. We could accept only a list then.