From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57008 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTNQH-0007kO-7J
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:39:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PTNQF-0001ru-Tn
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:39:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44429)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PTNQF-0001rh-Jh
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:39:43 -0500
Date: Fri, 17 Dec 2010 01:39:15 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101216233915.GE3878@redhat.com>
References: <20101213133615.GB2731@redhat.com>
	<AANLkTimrVzxcwxrTya0=Av2NDfbP_2tEvr6+vPjQzwJx@mail.gmail.com>
	<20101213161219.GA6715@redhat.com>
	<AANLkTikXEMUFdP-KUf13msbVf6Tpq2vU7=6k9bEVsUBQ@mail.gmail.com>
	<AANLkTimWANc_YOeguo=q45Mh5JyMzBLAuhu_u4C+pQoY@mail.gmail.com>
	<20101213185251.GA9554@redhat.com>
	<AANLkTi=jYxX=LWHgR05VqB3ZvamhRZJcRQ9XFmvbaUdE@mail.gmail.com>
	<20101215121423.GB1746@redhat.com>
	<AANLkTim9Nsyo97y+mw8q3VaZBhGV80QAYvkikiaTQDON@mail.gmail.com>
	<AANLkTi=uVN76GEzcaX9pQV1i9-Cdo21qb-270xQ9zKkb@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTi=uVN76GEzcaX9pQV1i9-Cdo21qb-270xQ9zKkb@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue
	notify
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On Thu, Dec 16, 2010 at 04:40:32PM +0000, Stefan Hajnoczi wrote:
> On Wed, Dec 15, 2010 at 12:59 PM, Stefan Hajnoczi <stefanha@gmail.com> =
wrote:
> > On Wed, Dec 15, 2010 at 12:14 PM, Michael S. Tsirkin <mst@redhat.com>=
 wrote:
> >> On Wed, Dec 15, 2010 at 11:42:12AM +0000, Stefan Hajnoczi wrote:
> >>> Are you happy with this patchset if I remove virtio-net-pci
> >>> ioeventfd=3Don|off so only virtio-blk-pci has ioeventfd=3Don|off (w=
ith
> >>> default on)? =A0For block we've found it to be a win and the initia=
l
> >>> results looked good for net too.
>=20
> Please let me know if I should disable ioeventfd for virtio-net.
>=20
> Stefan

Sure, if it slows us down, we should disable it.
What bothers me is the API issue that makes ioeventfd an all or nothing
thing, so it's enabled for the control vq needs to be resolved anyway.

Still it does not affect block, so maybe we can merge as is
and fix later ... I will try to think it over on the weekend.

--=20
MST