From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59966 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTNSe-0000oD-N0 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:42:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTNSd-00028c-3R for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:42:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTNSc-00028M-OJ for qemu-devel@nongnu.org; Thu, 16 Dec 2010 18:42:11 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBGNg9aZ012150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Dec 2010 18:42:10 -0500 Date: Fri, 17 Dec 2010 01:41:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20101216234147.GF3878@redhat.com> References: <20101216175516.6420.66081.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101216175516.6420.66081.stgit@s20.home> Subject: [Qemu-devel] Re: [PATCH 0/2] Fix rtl8139 migration with hotplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com On Thu, Dec 16, 2010 at 11:01:49AM -0700, Alex Williamson wrote: > Ok, I think this might actually make everyone happy, but I've been > known to be wrong about that many times before. Juan challenged me > to find an rtl8139 migration scenario that fails when hotplug is > not involved (and not switch device creation order since that's a > usage bug). I couldn't come up with one. We had been arguing that > a subsection didn't make sense for the change to rtl8139 vmstate > because the needed function would be {return 1}. but what if we > could detect if the VM had done any other hotplugs and only include > the subsection in those cases. That's what this short series does. > > So, I hope Juan is happy because this preserves the migration ABI > for the majority of the use cases, and I hope Michael is happy > because it does so using a subsection. Thanks, > > Alex I think it's a clever hack. Acked-by: Michael S. Tsirkin > --- > > Alex Williamson (2): > rtl8139: Use subsection to restrict migration after hotplug > qdev: Track runtime machine modifications > > > hw/qdev.c | 10 ++++++++++ > hw/qdev.h | 1 + > hw/rtl8139.c | 28 +++++++++++++++++++++++++++- > 3 files changed, 38 insertions(+), 1 deletions(-)