From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40310 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTwQF-00062I-Mo for qemu-devel@nongnu.org; Sat, 18 Dec 2010 08:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTwQE-00045J-N9 for qemu-devel@nongnu.org; Sat, 18 Dec 2010 08:02:03 -0500 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:56254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTwQE-00043s-2N for qemu-devel@nongnu.org; Sat, 18 Dec 2010 08:02:02 -0500 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp09.in.ibm.com (8.14.4/8.13.1) with ESMTP id oBICOBgN018980 for ; Sat, 18 Dec 2010 17:54:11 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBID1sOY3272924 for ; Sat, 18 Dec 2010 18:31:54 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBID1sEE000686 for ; Sat, 18 Dec 2010 18:31:54 +0530 Date: Sat, 18 Dec 2010 18:31:52 +0530 From: Kamalesh Babulal Message-ID: <20101218125646.GA13562@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Subject: [Qemu-devel] [PATCH] Fix build failure in assigned_device_pci_cap_init () Reply-To: Kamalesh Babulal List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com Hi, cb1983b880 build fails with CC x86_64-softmmu/device-assignment.o /other/srcs/qemu-kvm/hw/device-assignment.c: In function 'assigned_device_pci_cap_init': /other/srcs/qemu-kvm/hw/device-assignment.c:1463: error: 'PCI_PM_CTRL_NO_SOFT_RST' undeclared (first use in this function) /other/srcs/qemu-kvm/hw/device-assignment.c:1463: error: (Each undeclared identifier is reported only once /other/srcs/qemu-kvm/hw/device-assignment.c:1463: error: for each function it appears in.) I was able to build successfully, with the attached patch. Signed-off-by: Kamalesh Babulal -- hw/device-assignment.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 50c6408..8446cd4 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -1460,7 +1460,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev) /* assign_device will bring the device up to D0, so we don't need * to worry about doing that ourselves here. */ pci_set_word(pci_dev->config + pos + PCI_PM_CTRL, - PCI_PM_CTRL_NO_SOFT_RST); + PCI_PM_CTRL_NO_SOFT_RESET); pci_set_byte(pci_dev->config + pos + PCI_PM_PPB_EXTENSIONS, 0); pci_set_byte(pci_dev->config + pos + PCI_PM_DATA_REGISTER, 0); Kamalesh