From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: [Qemu-devel] Re: [PATCH v2] qbus: register reset handler for qbus whose parent is NULL
Date: Mon, 20 Dec 2010 15:43:41 +0900 [thread overview]
Message-ID: <20101220064341.GB8873@valinux.co.jp> (raw)
In-Reply-To: <20101220063524.GA31205@redhat.com>
On Mon, Dec 20, 2010 at 08:35:24AM +0200, Michael S. Tsirkin wrote:
> > diff --git a/hw/qdev.h b/hw/qdev.h
> > index aaaf55a..b239bb4 100644
> > --- a/hw/qdev.h
> > +++ b/hw/qdev.h
> > @@ -199,6 +199,8 @@ int qdev_walk_children(DeviceState *dev, qdev_walkerfn *devfn,
> > qbus_walkerfn *busfn, void *opaque);
> > void qdev_reset_all(DeviceState *dev);
> > void qbus_reset_all(BusState *bus);
>
> qbus_reset_all is unused now?
Yes, right now.
I kept it for consistency and type safety. Maybe a matter of taste.
If you don't like it, it can be dropped.
--
yamahata
next prev parent reply other threads:[~2010-12-20 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 5:33 [Qemu-devel] [PATCH v2] qbus: register reset handler for qbus whose parent is NULL Isaku Yamahata
2010-12-20 6:35 ` [Qemu-devel] " Michael S. Tsirkin
2010-12-20 6:43 ` Isaku Yamahata [this message]
2010-12-20 13:29 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220064341.GB8873@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).