From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56642 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUZTH-0006rl-Ad for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUZTE-0004Hx-8n for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:47 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:41833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUZTE-0004H9-1C for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:43:44 -0500 Date: Mon, 20 Dec 2010 15:43:41 +0900 From: Isaku Yamahata Message-ID: <20101220064341.GB8873@valinux.co.jp> References: <20101220063524.GA31205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101220063524.GA31205@redhat.com> Subject: [Qemu-devel] Re: [PATCH v2] qbus: register reset handler for qbus whose parent is NULL List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, aurelien@aurel32.net On Mon, Dec 20, 2010 at 08:35:24AM +0200, Michael S. Tsirkin wrote: > > diff --git a/hw/qdev.h b/hw/qdev.h > > index aaaf55a..b239bb4 100644 > > --- a/hw/qdev.h > > +++ b/hw/qdev.h > > @@ -199,6 +199,8 @@ int qdev_walk_children(DeviceState *dev, qdev_walkerfn *devfn, > > qbus_walkerfn *busfn, void *opaque); > > void qdev_reset_all(DeviceState *dev); > > void qbus_reset_all(BusState *bus); > > qbus_reset_all is unused now? Yes, right now. I kept it for consistency and type safety. Maybe a matter of taste. If you don't like it, it can be dropped. -- yamahata