From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46520 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUe0O-000418-CV
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 06:34:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PUe0J-0003IW-PY
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 06:34:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PUe0J-0003I7-H0
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 06:34:11 -0500
Date: Mon, 20 Dec 2010 08:47:46 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20101220104746.GC16707@amt.cnet>
References: <4D01CA58.3010306@cn.fujitsu.com> <20101210092026.2a1d037d@doriath>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101210092026.2a1d037d@doriath>
Subject: [Qemu-devel] Re: [PATCH v2 2/2] qemu,
 qmp: convert do_inject_nmi() to QObject, QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: avi@redhat.com, aliguori@us.ibm.com, Lai Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote:
> On Fri, 10 Dec 2010 14:36:08 +0800
> Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
> > +SQMP
> > +inject_nmi
> > +----------
> > +
> > +Inject an NMI on the given CPU (x86 only).
> > +
> > +Arguments:
> > +
> > +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> > +
> > +Example:
> > +
> > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> > +<- { "return": {} }
> > +
> > +EQMP
> > +
> 
> Avi, Anthony, can you please review this? Do we expect some kind of ack from
> the guest? Do we expect it respond in some way?

Looks good to me. Don't except any response from the guest.

> Also note that the current series defines only one error condition: invalid
> cpu index. Can this fail in other ways?
> --

Not really. An NMI can be pending already (which means the current
command has no effect), but i don't see the need to report that.