From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43635 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUjep-0003PT-OJ
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:36:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PUjFd-0003dg-IK
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:10:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PUjFd-0003dU-BK
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:10:21 -0500
Date: Mon, 20 Dec 2010 15:05:01 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20101220170501.GA30587@amt.cnet>
References: <20101208170858.GA10056@amt.cnet>
	<20101212191129.GA20312@morn.localdomain>
	<20101212194916.GD28665@redhat.com>
	<20101212195745.GA23475@morn.localdomain>
	<20101220084948.GA16707@amt.cnet> <4D0F1EBC.9050205@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D0F1EBC.9050205@redhat.com>
Subject: [Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method
	for PCI devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin O'Connor <kevin@koconnor.net>, seabios@seabios.org, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

On Mon, Dec 20, 2010 at 11:15:40AM +0200, Avi Kivity wrote:
> On 12/20/2010 10:49 AM, Marcelo Tosatti wrote:
> >On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote:
> >>  On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote:
> >>  >  On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote:
> >>  >  >  On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote:
> >>  >  >  >  Use _RMV method to indicate whether device can be removed.
> >>  >  >  >
> >>  >  >  >  Data is retrieved from QEMU via I/O port 0xae0c.
> >>  >  >  >
> >>  >  >  >  Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
> >>  >  >
> >>  >  >  Thanks Marcelo,
> >>  >  >
> >>  >  >  Can you add acked-bys from the qemu/kvm maintaners?
> >>  >  >
> >>  >  Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7&  XP
> >>  >  and it works as expected. The patch relies on patch not yes excepted
> >>  >  to qemu though.
> >>
> >>  Yeah - I know - but I figured I'd ask for concensus before committing.
> >>  :-)
> >>
> >>  The committing of seabios patches that have a dependency on qemu/kvm
> >>  is an area that I think could be better clarified.  I'm thinking that
> >>  if the seabios part depends on something in qemu/kvm then we should
> >>  have the corresponding kvm/qemu maintaners "ack" it.
> >>
> >>  -Kevin
> >
> >Avi, are you OK with this patch ?
> >
> >Yes, perhaps it all (including PCI hotplug controller) should be using
> >something else than hardcoded IO ports, but thats what we have now.
> 
> At least it should be documented.
> 
> What's the behaviour with a qemu that doesn't support the new port?
> We don't strictly support it, but let's do so if we can.

All slots will be marked as hotpluggable (since the "removability" IO port will not be
registered and return all 1's).