* [Qemu-devel] [PATCH] x86: Filter out garbage from segment flags dump
@ 2010-12-27 14:52 Jan Kiszka
2010-12-27 21:03 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-12-27 14:52 UTC (permalink / raw)
To: qemu-devel
From: Jan Kiszka <jan.kiszka@siemens.com>
Only bits 8..23 of the segment flags contain valid data, so only dump
those when printing the CPU state.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
target-i386/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 26ea1e5..25a3e36 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -175,12 +175,12 @@ cpu_x86_dump_seg_cache(CPUState *env, FILE *f, fprintf_function cpu_fprintf,
#ifdef TARGET_X86_64
if (env->hflags & HF_CS64_MASK) {
cpu_fprintf(f, "%-3s=%04x %016" PRIx64 " %08x %08x", name,
- sc->selector, sc->base, sc->limit, sc->flags);
+ sc->selector, sc->base, sc->limit, sc->flags & 0x00ffff00);
} else
#endif
{
cpu_fprintf(f, "%-3s=%04x %08x %08x %08x", name, sc->selector,
- (uint32_t)sc->base, sc->limit, sc->flags);
+ (uint32_t)sc->base, sc->limit, sc->flags & 0x00ffff00);
}
if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] x86: Filter out garbage from segment flags dump
2010-12-27 14:52 [Qemu-devel] [PATCH] x86: Filter out garbage from segment flags dump Jan Kiszka
@ 2010-12-27 21:03 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-12-27 21:03 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
On Mon, Dec 27, 2010 at 03:52:24PM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Only bits 8..23 of the segment flags contain valid data, so only dump
> those when printing the CPU state.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> target-i386/helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 26ea1e5..25a3e36 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -175,12 +175,12 @@ cpu_x86_dump_seg_cache(CPUState *env, FILE *f, fprintf_function cpu_fprintf,
> #ifdef TARGET_X86_64
> if (env->hflags & HF_CS64_MASK) {
> cpu_fprintf(f, "%-3s=%04x %016" PRIx64 " %08x %08x", name,
> - sc->selector, sc->base, sc->limit, sc->flags);
> + sc->selector, sc->base, sc->limit, sc->flags & 0x00ffff00);
> } else
> #endif
> {
> cpu_fprintf(f, "%-3s=%04x %08x %08x %08x", name, sc->selector,
> - (uint32_t)sc->base, sc->limit, sc->flags);
> + (uint32_t)sc->base, sc->limit, sc->flags & 0x00ffff00);
> }
>
> if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
> --
> 1.7.1
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-27 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-27 14:52 [Qemu-devel] [PATCH] x86: Filter out garbage from segment flags dump Jan Kiszka
2010-12-27 21:03 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).