From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55021 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PZ2eT-00037E-Hc
	for qemu-devel@nongnu.org; Sat, 01 Jan 2011 09:41:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bounces@canonical.com>) id 1PZ2eS-00049Y-Fe
	for qemu-devel@nongnu.org; Sat, 01 Jan 2011 09:41:49 -0500
Received: from adelie.canonical.com ([91.189.90.139]:34354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounces@canonical.com>) id 1PZ2eS-00049T-7y
	for qemu-devel@nongnu.org; Sat, 01 Jan 2011 09:41:48 -0500
Received: from loganberry.canonical.com ([91.189.90.37])
	by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian))
	id 1PZ2eO-0006em-Jy
	for <qemu-devel@nongnu.org>; Sat, 01 Jan 2011 14:41:45 +0000
Received: from loganberry.canonical.com (localhost [127.0.0.1])
	by loganberry.canonical.com (Postfix) with ESMTP id 9B2C72E8264
	for <qemu-devel@nongnu.org>; Sat,  1 Jan 2011 14:41:16 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 01 Jan 2011 14:34:37 -0000
From: Aurelien Jarno <aurel32@debian.org>
Sender: bounces@canonical.com
References: <20100522092104.29268.17427.malonedeb@soybean.canonical.com>
Message-Id: <20110101143438.20128.68308.launchpad@soybean.canonical.com>
Errors-To: bounces@canonical.com
Subject: [Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number
Reply-To: Bug 584143 <584143@bugs.launchpad.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

** Changed in: qemu
       Status: In Progress =3D> Fix Committed

-- =

You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Committed
Status in =E2=80=9Cqemu-kvm=E2=80=9D package in Ubuntu:
  Triaged
Status in =E2=80=9Cqemu-kvm=E2=80=9D source package in Lucid:
  Confirmed
Status in =E2=80=9Cqemu-kvm=E2=80=9D package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=3Dxyz option is broken, at least in 0.12.  See Debi=
an bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D573439 fo=
r details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error =3D on_write_error;
     dinfo->opts =3D opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive =3D dinfo;