[Qemu-devel] [Bug 584143] [NEW] qemu fails to set hdd serial number

[Qemu-devel] [Bug 584143] [NEW] qemu fails to set hdd serial number

[Michael Tokarev]

Public bug reported:

The -drive ...,serial=xyz option is broken, at least in 0.12.  See
Debian bug#573439, http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

** Affects: qemu
     Importance: Undecided
         Status: New


** Tags: patch

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Loïc Minier]

Patch still applies on top of qemu-kvm.git and qemu.git

** Bug watch added: Debian Bug tracker #573439
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439

** Also affects: qemu-kvm (Debian) via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439
   Importance: Unknown
       Status: Unknown

** Also affects: qemu-kvm (Ubuntu)
   Importance: Undecided
       Status: New

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “qemu-kvm” package in Ubuntu: New
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[C de-Avillez]

Marking Triaged/Medium. Debian has accepted the patch, and a new
(patched) package is in Unstable. May be considered for SRU-ing into
10.04 LTS, so nominating.

** Changed in: qemu-kvm (Ubuntu)
   Importance: Undecided => Medium

** Changed in: qemu-kvm (Ubuntu)
       Status: New => Triaged

** Also affects: qemu-kvm (Ubuntu Lucid)
   Importance: Undecided
       Status: New

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “qemu-kvm” package in Ubuntu: Triaged
Status in “qemu-kvm” source package in Lucid: New
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Luiz Capitulino]

Bug exists in both current master and stable v0.12.4, but the suggested
fix doesn't leave room for the null terminating byte, will submit
upstream a better version.

** Changed in: qemu
       Status: New => In Progress

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: In Progress
Status in “qemu-kvm” package in Ubuntu: Triaged
Status in “qemu-kvm” source package in Lucid: New
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Rob]

** Changed in: qemu-kvm (Ubuntu Lucid)
       Status: New => Confirmed

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: In Progress
Status in “qemu-kvm” package in Ubuntu: Triaged
Status in “qemu-kvm” source package in Lucid: Confirmed
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Коренберг Марк]

-drive file=/dev/mmwork/testl7,if=ide,index=0,boot=on,format=raw,serial
=WD-WMAM9TD73523,cache=writeback

Yeah, bug exists. only WD-W serial is seen inside VM.

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: In Progress
Status in “qemu-kvm” package in Ubuntu: Triaged
Status in “qemu-kvm” source package in Lucid: Confirmed
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Aurelien Jarno]

** Changed in: qemu
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Committed
Status in “qemu-kvm” package in Ubuntu:
  Triaged
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Aurelien Jarno]

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Triaged
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

Patch with fix is at http://patchwork.ozlabs.org/patch/77142/mbox/.  It
is in 0.14.0 so marked natty bug as fix released.  I will propose merge
of the fix for maverick and lucid.

** Changed in: qemu-kvm (Ubuntu)
     Assignee: (unassigned) => Serge Hallyn (serge-hallyn)

** Also affects: qemu-kvm (Ubuntu Maverick)
   Importance: Undecided
       Status: New

** Changed in: qemu-kvm (Ubuntu)
       Status: Triaged => Fix Released

** Changed in: qemu-kvm (Ubuntu Lucid)
     Assignee: (unassigned) => Serge Hallyn (serge-hallyn)

** Changed in: qemu-kvm (Ubuntu Maverick)
     Assignee: (unassigned) => Serge Hallyn (serge-hallyn)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” source package in Maverick:
  New
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Launchpad Bug Tracker]

** Branch linked: lp:~serge-hallyn/ubuntu/lucid/qemu-kvm/hdd-serial

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” source package in Maverick:
  New
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Launchpad Bug Tracker]

** Branch linked: lp:~serge-hallyn/ubuntu/maverick/qemu-kvm/hdd-serial

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” source package in Maverick:
  New
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

** Attachment added: "amd64 debs for lucid"
   https://bugs.launchpad.net/qemu/+bug/584143/+attachment/1909175/+files/hdd-lucid-debs.tgz

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” source package in Maverick:
  New
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

** Attachment added: "amd64 debs for maverick"
   https://bugs.launchpad.net/qemu/+bug/584143/+attachment/1909178/+files/hdd-mav-debs.tgz

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  Confirmed
Status in “qemu-kvm” source package in Maverick:
  New
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

** Changed in: qemu-kvm (Ubuntu Maverick)
       Status: New => In Progress

** Changed in: qemu-kvm (Ubuntu Lucid)
       Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  In Progress
Status in “qemu-kvm” source package in Maverick:
  In Progress
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

Please test the packages uploaded in comment #6 (or, if you're on
maverick, comment #7) and comment if they work for you.  Once verified
we can merge the linked bzr trees.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  In Progress
Status in “qemu-kvm” source package in Maverick:
  In Progress
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

** Description changed:

+ =========================================
+ SRU Justification:
+ 1. Impact: 'qemu -drive ...,serial=xyz' does not work
+ 2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
+ 3. patch: is in the description
+ 4. to reproduce: use '-drive ...,serial=xyz' option to qemu
+ 5. regression potential:  this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
+ =========================================
+ 
  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.
  
  The proposed fix from the original reporter:
  
  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
-      dinfo->on_write_error = on_write_error;
-      dinfo->opts = opts;
-      if (serial)
+      dinfo->on_write_error = on_write_error;
+      dinfo->opts = opts;
+      if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
-      QTAILQ_INSERT_TAIL(&drives, dinfo, next);
-      if (is_extboot) {
-          extboot_drive = dinfo;
+      QTAILQ_INSERT_TAIL(&drives, dinfo, next);
+      if (is_extboot) {
+          extboot_drive = dinfo;

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  In Progress
Status in “qemu-kvm” source package in Maverick:
  In Progress
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  =========================================
  SRU Justification:
  1. Impact: 'qemu -drive ...,serial=xyz' does not work
  2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
  3. patch: is in the description
  4. to reproduce: use '-drive ...,serial=xyz' option to qemu
  5. regression potential:  this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
  =========================================

  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Serge Hallyn]

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  In Progress
Status in “qemu-kvm” source package in Maverick:
  In Progress
Status in “qemu-kvm” package in Debian:
  Unknown

Bug description:
  =========================================
  SRU Justification:
  1. Impact: 'qemu -drive ...,serial=xyz' does not work
  2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
  3. patch: is in the description
  4. to reproduce: use '-drive ...,serial=xyz' option to qemu
  5. regression potential:  this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
  =========================================

  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Bug Watch Updater]

** Changed in: qemu-kvm (Debian)
       Status: Unknown => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” source package in Lucid:
  In Progress
Status in “qemu-kvm” source package in Maverick:
  In Progress
Status in “qemu-kvm” package in Debian:
  Fix Released

Bug description:
  =========================================
  SRU Justification:
  1. Impact: 'qemu -drive ...,serial=xyz' does not work
  2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
  3. patch: is in the description
  4. to reproduce: use '-drive ...,serial=xyz' option to qemu
  5. regression potential:  this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
  =========================================

  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/584143/+subscriptions

[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[Adolfo Jayme Barrientos]

** No longer affects: qemu-kvm (Ubuntu Lucid)

** No longer affects: qemu-kvm (Ubuntu Maverick)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/584143

Title:
  qemu fails to set hdd serial number

Status in QEMU:
  Fix Released
Status in “qemu-kvm” package in Ubuntu:
  Fix Released
Status in “qemu-kvm” package in Debian:
  Fix Released

Bug description:
  =========================================
  SRU Justification:
  1. Impact: 'qemu -drive ...,serial=xyz' does not work
  2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
  3. patch: is in the description
  4. to reproduce: use '-drive ...,serial=xyz' option to qemu
  5. regression potential:  this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
  =========================================

  The -drive ...,serial=xyz option is broken, at least in 0.12.  See
  Debian bug#573439, http://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=573439 for details.

  The proposed fix from the original reporter:

  --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
  +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
  @@ -2397,7 +2397,7 @@
       dinfo->on_write_error = on_write_error;
       dinfo->opts = opts;
       if (serial)
  -        strncpy(dinfo->serial, serial, sizeof(serial));
  +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
       if (is_extboot) {
           extboot_drive = dinfo;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/584143/+subscriptions