From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52350 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZMXv-0007Bf-4R for qemu-devel@nongnu.org; Sun, 02 Jan 2011 06:56:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZMXt-0004JB-DL for qemu-devel@nongnu.org; Sun, 02 Jan 2011 06:56:23 -0500 Received: from hall.aurel32.net ([88.191.126.93]:53658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZMXt-0004Iq-8b for qemu-devel@nongnu.org; Sun, 02 Jan 2011 06:56:21 -0500 Date: Sun, 2 Jan 2011 12:56:14 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan() Message-ID: <20110102115614.GA26845@volta.aurel32.net> References: <1292601366-990-1-git-send-email-peter.maydell@linaro.org> <20110102103105.GT3615@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Edgar E. Iglesias" , qemu-devel@nongnu.org, Nathan Froyd On Sun, Jan 02, 2011 at 11:12:32AM +0000, Peter Maydell wrote: > On 2 January 2011 10:31, Aurelien Jarno wrote: > > On Sat, Jan 01, 2011 at 11:46:16PM +0000, Peter Maydell wrote: > >> Can it be applied please? (cc'd Aurelien since you seem to be > >> committing various missed patches at the moment :-)) > > > > Sorry, I understood there was a conflict with another patch series, and > > it was better to wait. Committed now. > > Thanks. > > > As a side note, there are now a few places where the following code is > > present: > > > >  float32_is_quiet_nan(x) || float32_is_signaling_nan(x) > > > > It might be a good idea to add back a function float32_is_nan() that > > this time checks for both quiet and signaling NaN. > > This is already present as float32_is_any_nan() (I added it as > part of one of the earlier ARM patchsets). > Ok, then I am going to produce a cleanup patch to use it. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net