* [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index
@ 2010-12-20 6:11 Lai Jiangshan
2010-12-20 17:00 ` Markus Armbruster
0 siblings, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2010-12-20 6:11 UTC (permalink / raw)
To: Luiz Capitulino, Markus Armbruster, qemu-devel, aliguori, kvm,
Avi Kivity
"cpu-index" is better name.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 4befbe2..8de7aa3 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -721,7 +721,7 @@ ETEXI
#if defined(TARGET_I386)
{
.name = "nmi",
- .args_type = "cpu_index:i",
+ .args_type = "cpu-index:i",
.params = "cpu",
.help = "inject an NMI on the given CPU",
.mhandler.cmd = do_inject_nmi,
diff --git a/monitor.c b/monitor.c
index 5d74fe3..c16b39d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
static void do_inject_nmi(Monitor *mon, const QDict *qdict)
{
CPUState *env;
- int cpu_index = qdict_get_int(qdict, "cpu_index");
+ int cpu_index = qdict_get_int(qdict, "cpu-index");
for (env = first_cpu; env != NULL; env = env->next_cpu)
if (env->cpu_index == cpu_index) {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index
2010-12-20 6:11 [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index Lai Jiangshan
@ 2010-12-20 17:00 ` Markus Armbruster
2010-12-21 6:05 ` Lai Jiangshan
2011-01-03 13:50 ` Luiz Capitulino
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2010-12-20 17:00 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: aliguori, Avi Kivity, qemu-devel, kvm, Luiz Capitulino
Lai Jiangshan <laijs@cn.fujitsu.com> writes:
> "cpu-index" is better name.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 4befbe2..8de7aa3 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -721,7 +721,7 @@ ETEXI
> #if defined(TARGET_I386)
> {
> .name = "nmi",
> - .args_type = "cpu_index:i",
> + .args_type = "cpu-index:i",
> .params = "cpu",
> .help = "inject an NMI on the given CPU",
> .mhandler.cmd = do_inject_nmi,
> diff --git a/monitor.c b/monitor.c
> index 5d74fe3..c16b39d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
> static void do_inject_nmi(Monitor *mon, const QDict *qdict)
> {
> CPUState *env;
> - int cpu_index = qdict_get_int(qdict, "cpu_index");
> + int cpu_index = qdict_get_int(qdict, "cpu-index");
>
> for (env = first_cpu; env != NULL; env = env->next_cpu)
> if (env->cpu_index == cpu_index) {
Fine with me, but it would be nice if we could make up our mind once and
for all whether to use dash or underscore in monitor commands and
arguments.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index
2010-12-20 17:00 ` Markus Armbruster
@ 2010-12-21 6:05 ` Lai Jiangshan
2011-01-03 13:50 ` Luiz Capitulino
1 sibling, 0 replies; 4+ messages in thread
From: Lai Jiangshan @ 2010-12-21 6:05 UTC (permalink / raw)
To: Markus Armbruster; +Cc: aliguori, Avi Kivity, qemu-devel, kvm, Luiz Capitulino
On 12/21/2010 01:00 AM, Markus Armbruster wrote:
> Lai Jiangshan <laijs@cn.fujitsu.com> writes:
>
>> "cpu-index" is better name.
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> ---
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 4befbe2..8de7aa3 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -721,7 +721,7 @@ ETEXI
>> #if defined(TARGET_I386)
>> {
>> .name = "nmi",
>> - .args_type = "cpu_index:i",
>> + .args_type = "cpu-index:i",
>> .params = "cpu",
>> .help = "inject an NMI on the given CPU",
>> .mhandler.cmd = do_inject_nmi,
>> diff --git a/monitor.c b/monitor.c
>> index 5d74fe3..c16b39d 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
>> static void do_inject_nmi(Monitor *mon, const QDict *qdict)
>> {
>> CPUState *env;
>> - int cpu_index = qdict_get_int(qdict, "cpu_index");
>> + int cpu_index = qdict_get_int(qdict, "cpu-index");
>>
>> for (env = first_cpu; env != NULL; env = env->next_cpu)
>> if (env->cpu_index == cpu_index) {
>
> Fine with me, but it would be nice if we could make up our mind once and
> for all whether to use dash or underscore in monitor commands and
> arguments.
>
Currently, I focus on this nmi command, our customers hope they
can inject nmi via libvirt. I may also fix other "underscore"
when these patches applied.
Thanks,
Lai
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index
2010-12-20 17:00 ` Markus Armbruster
2010-12-21 6:05 ` Lai Jiangshan
@ 2011-01-03 13:50 ` Luiz Capitulino
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2011-01-03 13:50 UTC (permalink / raw)
To: Markus Armbruster; +Cc: aliguori, Avi Kivity, Lai Jiangshan, kvm, qemu-devel
On Mon, 20 Dec 2010 18:00:34 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Lai Jiangshan <laijs@cn.fujitsu.com> writes:
>
> > "cpu-index" is better name.
> >
> > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> > ---
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index 4befbe2..8de7aa3 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -721,7 +721,7 @@ ETEXI
> > #if defined(TARGET_I386)
> > {
> > .name = "nmi",
> > - .args_type = "cpu_index:i",
> > + .args_type = "cpu-index:i",
> > .params = "cpu",
> > .help = "inject an NMI on the given CPU",
> > .mhandler.cmd = do_inject_nmi,
> > diff --git a/monitor.c b/monitor.c
> > index 5d74fe3..c16b39d 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
> > static void do_inject_nmi(Monitor *mon, const QDict *qdict)
> > {
> > CPUState *env;
> > - int cpu_index = qdict_get_int(qdict, "cpu_index");
> > + int cpu_index = qdict_get_int(qdict, "cpu-index");
> >
> > for (env = first_cpu; env != NULL; env = env->next_cpu)
> > if (env->cpu_index == cpu_index) {
>
> Fine with me, but it would be nice if we could make up our mind once and
> for all whether to use dash or underscore in monitor commands and
> arguments.
I vote for dash, although we obviously can't change existing commands.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-03 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-20 6:11 [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index Lai Jiangshan
2010-12-20 17:00 ` Markus Armbruster
2010-12-21 6:05 ` Lai Jiangshan
2011-01-03 13:50 ` Luiz Capitulino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).