From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 02/13] Introduce work concept in posix-aio-compat.c
Date: Tue, 04 Jan 2011 10:57:13 +0530 [thread overview]
Message-ID: <20110104052713.15887.19301.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20110104052627.15887.43436.stgit@localhost6.localdomain6>
This patch introduces work concept by introducing the
ThreadletWork structure.
Signed-off-by: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
---
posix-aio-compat.c | 20 ++++++++++++++------
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/posix-aio-compat.c b/posix-aio-compat.c
index ae5e20e..de52eb5 100644
--- a/posix-aio-compat.c
+++ b/posix-aio-compat.c
@@ -33,6 +33,10 @@
static QemuMutex aiocb_mutex;
static QemuCond aiocb_completion;
+typedef struct ThreadletWork
+{
+ QTAILQ_ENTRY(ThreadletWork) node;
+} ThreadletWork;
struct qemu_paiocb {
BlockDriverAIOCB common;
@@ -47,13 +51,13 @@ struct qemu_paiocb {
int ev_signo;
off_t aio_offset;
- QTAILQ_ENTRY(qemu_paiocb) node;
int aio_type;
ssize_t ret;
int active;
struct qemu_paiocb *next;
int async_context_id;
+ ThreadletWork work;
};
typedef struct PosixAioState {
@@ -69,7 +73,7 @@ static pthread_attr_t attr;
static int max_threads = 64;
static int cur_threads = 0;
static int idle_threads = 0;
-static QTAILQ_HEAD(, qemu_paiocb) request_list;
+static QTAILQ_HEAD(, ThreadletWork) request_list;
#ifdef CONFIG_PREADV
static int preadv_present = 1;
@@ -307,6 +311,7 @@ static ssize_t handle_aiocb_rw(struct qemu_paiocb *aiocb)
static void *aio_thread(void *unused)
{
pid_t pid;
+ ThreadletWork *work;
pid = getpid();
@@ -330,8 +335,11 @@ static void *aio_thread(void *unused)
if (QTAILQ_EMPTY(&request_list))
break;
- aiocb = QTAILQ_FIRST(&request_list);
- QTAILQ_REMOVE(&request_list, aiocb, node);
+ work = QTAILQ_FIRST(&request_list);
+ QTAILQ_REMOVE(&request_list, work, node);
+
+ aiocb = container_of(work, struct qemu_paiocb, work);
+
aiocb->active = 1;
idle_threads--;
mutex_unlock(&lock);
@@ -398,7 +406,7 @@ static void qemu_paio_submit(struct qemu_paiocb *aiocb)
mutex_lock(&lock);
if (idle_threads == 0 && cur_threads < max_threads)
spawn_thread();
- QTAILQ_INSERT_TAIL(&request_list, aiocb, node);
+ QTAILQ_INSERT_TAIL(&request_list, &aiocb->work, node);
mutex_unlock(&lock);
cond_signal(&cond);
}
@@ -548,7 +556,7 @@ static void paio_cancel(BlockDriverAIOCB *blockacb)
mutex_lock(&lock);
if (!acb->active) {
- QTAILQ_REMOVE(&request_list, acb, node);
+ QTAILQ_REMOVE(&request_list, &acb->work, node);
acb->ret = -ECANCELED;
} else if (acb->ret == -EINPROGRESS) {
active = 1;
next prev parent reply other threads:[~2011-01-04 5:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 5:27 [Qemu-devel] [PATCH 00/13] Threadlets infrastructure Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 01/13] Add aiocb_mutex and aiocb_completion Arun R Bharadwaj
2011-01-05 19:53 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:27 ` Arun R Bharadwaj
2011-01-04 5:27 ` Arun R Bharadwaj [this message]
2011-01-04 5:27 ` [Qemu-devel] [PATCH 03/13] Add callback function to ThreadletWork structure Arun R Bharadwaj
2011-01-05 19:54 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:24 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 04/13] Add ThreadletQueue Arun R Bharadwaj
2011-01-05 19:54 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-07 6:06 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 05/13] Threadlet: Add submit_work threadlet API Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 06/13] Threadlet: Add dequeue_work " Arun R Bharadwaj
2011-01-05 19:55 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:43 ` Arun R Bharadwaj
2011-01-07 11:06 ` Stefan Hajnoczi
2011-01-04 5:27 ` [Qemu-devel] [PATCH 07/13] Remove active field in qemu_aiocb structure Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 08/13] Remove thread_create routine Arun R Bharadwaj
2011-01-05 19:56 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-07 5:59 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 09/13] Threadlet: Add aio_signal_handler threadlet API Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 10/13] Remove all instances of CONFIG_THREAD Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 11/13] Move threadlet code to qemu-threadlets.c Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 12/13] Threadlets: Add functionality to create private queues Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 13/13] Threadlets: Add documentation Arun R Bharadwaj
2011-01-04 23:13 ` [Qemu-devel] [PATCH 00/13] Threadlets infrastructure Venkateswararao Jujjuri (JV)
2011-01-05 1:43 ` Arun R Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104052713.15887.19301.stgit@localhost6.localdomain6 \
--to=arun@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).