From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59805 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pa48G-0003oq-Ki
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 05:28:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Pa48F-0000Od-HC
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 05:28:48 -0500
Received: from mtagate7.uk.ibm.com ([194.196.100.167]:33775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Pa48F-0000ML-91
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 05:28:47 -0500
Received: from d06nrmr1507.portsmouth.uk.ibm.com
	(d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233])
	by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p04ASdPY013681
	for <qemu-devel@nongnu.org>; Tue, 4 Jan 2011 10:28:39 GMT
Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com
	[9.149.37.249])
	by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id p04ASflx2961580
	for <qemu-devel@nongnu.org>; Tue, 4 Jan 2011 10:28:41 GMT
Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id p04ASdtw000467
	for <qemu-devel@nongnu.org>; Tue, 4 Jan 2011 10:28:39 GMT
Date: Tue, 4 Jan 2011 10:28:33 +0000
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20110104102832.GA3357@stefanha-thinkpad.localdomain>
References: <1292587312-24511-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<20101229145245.GA8847@redhat.com>
	<20110103163852.GA18143@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110103163852.GA18143@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] ioeventfd: minor fixups
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 03, 2011 at 06:38:53PM +0200, Michael S. Tsirkin wrote:
> On Wed, Dec 29, 2010 at 04:52:46PM +0200, Michael S. Tsirkin wrote:
> > This is on top of the ioeventfd patches, and
> > fixes two potential issues when ioeventfd is mixed with vhost-net:
> > - ioeventfd could start running then get stopped for vhost-net.
> >   For example, vm state change handlers run in no particular order.
> >   This would be hard to debug. Prevent this by always running state
> >   callback before ioeventfd start and after ioeventfd stop.
> > - Separate the flags for user-requested ioeventfd and for ioeventfd
> >   being overridden by vhost backend.
> >   This will make it possible to enable/disable vhost depending on
> >   guest behaviour.
> > 
> > I'll probably split this patch in two, and merge into the
> > appropriate patches in the ioeventfd series.
> > 
> > Compile-tested only so far, would appreciate feedback/test reports.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> 
> Stefan - just to clarify, I'm waiting for you ack
> to merge this + the ioeventfd patches.

Back from the holidays today.  Will send feedback/ack later today.

Stefan