From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36311 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PaB4Y-0006l0-3Y
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 12:53:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PaB4W-0003ki-Ig
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 12:53:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46433)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PaB4W-0003k9-Bq
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 12:53:24 -0500
Date: Tue, 4 Jan 2011 19:53:01 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ioeventfd: minor fixups
Message-ID: <20110104175301.GG5694@redhat.com>
References: <1292587312-24511-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<20101229145245.GA8847@redhat.com>
	<AANLkTim-fsHFhPVBKRhPCn5O_RApDX1_5YUNKnQjv3HW@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTim-fsHFhPVBKRhPCn5O_RApDX1_5YUNKnQjv3HW@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Tue, Jan 04, 2011 at 04:57:43PM +0000, Stefan Hajnoczi wrote:
> On Wed, Dec 29, 2010 at 2:52 PM, Michael S. Tsirkin <mst@redhat.com> wr=
ote:
> > I'll probably split this patch in two, and merge into the
> > appropriate patches in the ioeventfd series.
> >
> > Compile-tested only so far, would appreciate feedback/test reports.
>=20
> virtio-ioeventfd works as expected.
>=20
> > diff --git a/hw/vhost.c b/hw/vhost.c
> > index 6082da2..1d09ed0 100644
> > --- a/hw/vhost.c
> > +++ b/hw/vhost.c
> > @@ -630,6 +630,17 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
> > =A0int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
> > =A0{
> > =A0 =A0 int i, r;
> > + =A0 =A0/* A binding must support vmstate notifiers (for migration t=
o work) */
> > + =A0 =A0if (!vdev->binding->vmstate_change) {
> > + =A0 =A0 =A0 =A0fprintf(stderr, "binding does not support vmstate no=
tifiers\n");
> > + =A0 =A0 =A0 =A0r =3D -ENOSYS;
> > + =A0 =A0 =A0 =A0goto fail;
> > + =A0 =A0}
> > + =A0 =A0if (!vdev->binding->set_guest_notifiers) {
> > + =A0 =A0 =A0 =A0fprintf(stderr, "binding does not support guest noti=
fiers\n");
> > + =A0 =A0 =A0 =A0r =3D -ENOSYS;
> > + =A0 =A0 =A0 =A0goto fail;
> > + =A0 =A0}
>=20
> Merge error?  The set_guest_notifiers check is already present.
>=20
> Stefan

OK I need to test with/without vhost-net and merge then.

Thanks!