From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59094 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PaChS-0000CW-3O for qemu-devel@nongnu.org; Tue, 04 Jan 2011 14:37:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PaChQ-0004Tr-VJ for qemu-devel@nongnu.org; Tue, 04 Jan 2011 14:37:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PaChQ-0004TQ-Lz for qemu-devel@nongnu.org; Tue, 04 Jan 2011 14:37:40 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p04Jbc3E024562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jan 2011 14:37:38 -0500 From: Alex Williamson Date: Tue, 04 Jan 2011 12:37:37 -0700 Message-ID: <20110104192739.1909.73162.stgit@s20.home> In-Reply-To: <20101216175516.6420.66081.stgit@s20.home> References: <20101216175516.6420.66081.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RESEND PATCH 0/2] Fix rtl8139 migration with hotplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, mst@redhat.com, quintela@redhat.com rtl8139 includes a cpu_register_io_memory() in it's vmstate. This is problematic if the guest undergoes hotplug operations, which can shift io indexes between migration source and target. Add an interface to detect this condition and add a subsection, when necessary, to ensure we migrate to a safe target. This resolves Juan's concerns about maintaining the migration ABI and Michael's concerns wrt subsections. Acked by both. Please apply. Thanks, Alex --- Alex Williamson (2): rtl8139: Use subsection to restrict migration after hotplug qdev: Track runtime machine modifications hw/qdev.c | 10 ++++++++++ hw/qdev.h | 1 + hw/rtl8139.c | 28 +++++++++++++++++++++++++++- 3 files changed, 38 insertions(+), 1 deletions(-)