qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: [Qemu-devel] Re: [RESEND PATCH 0/2] Fix rtl8139 migration with hotplug
Date: Wed, 5 Jan 2011 12:13:07 +0200	[thread overview]
Message-ID: <20110105101307.GA14558@redhat.com> (raw)
In-Reply-To: <20110104192739.1909.73162.stgit@s20.home>

On Tue, Jan 04, 2011 at 12:37:37PM -0700, Alex Williamson wrote:
> rtl8139 includes a cpu_register_io_memory() in it's vmstate.  This
> is problematic if the guest undergoes hotplug operations, which can
> shift io indexes between migration source and target.  Add an
> interface to detect this condition and add a subsection, when
> necessary, to ensure we migrate to a safe target.
> 
> This resolves Juan's concerns about maintaining the migration ABI
> and Michael's concerns wrt subsections.  Acked by both.  Please apply.
> Thanks,
> 
> Alex

Applied, thanks!

> ---
> 
> Alex Williamson (2):
>       rtl8139: Use subsection to restrict migration after hotplug
>       qdev: Track runtime machine modifications
> 
> 
>  hw/qdev.c    |   10 ++++++++++
>  hw/qdev.h    |    1 +
>  hw/rtl8139.c |   28 +++++++++++++++++++++++++++-
>  3 files changed, 38 insertions(+), 1 deletions(-)

      parent reply	other threads:[~2011-01-05 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 18:01 [Qemu-devel] [PATCH 0/2] Fix rtl8139 migration with hotplug Alex Williamson
2010-12-16 18:02 ` [Qemu-devel] [PATCH 1/2] qdev: Track runtime machine modifications Alex Williamson
2010-12-16 18:02 ` [Qemu-devel] [PATCH 2/2] rtl8139: Use subsection to restrict migration after hotplug Alex Williamson
2010-12-16 23:41 ` [Qemu-devel] Re: [PATCH 0/2] Fix rtl8139 migration with hotplug Michael S. Tsirkin
2010-12-17  1:35 ` Juan Quintela
2011-01-04 19:37 ` [Qemu-devel] [RESEND PATCH " Alex Williamson
2011-01-04 19:37   ` [Qemu-devel] [RESEND PATCH 1/2] qdev: Track runtime machine modifications Alex Williamson
2011-01-12 12:09     ` Markus Armbruster
2011-01-12 13:51       ` Alex Williamson
2011-01-04 19:38   ` [Qemu-devel] [RESEND PATCH 2/2] rtl8139: Use subsection to restrict migration after hotplug Alex Williamson
2011-01-05 10:13   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105101307.GA14558@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).