From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53813 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PaQMx-000595-OG for qemu-devel@nongnu.org; Wed, 05 Jan 2011 05:13:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PaQMw-0006JE-DD for qemu-devel@nongnu.org; Wed, 05 Jan 2011 05:13:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PaQMw-0006J4-3e for qemu-devel@nongnu.org; Wed, 05 Jan 2011 05:13:26 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p05ADOiA013046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jan 2011 05:13:25 -0500 Date: Wed, 5 Jan 2011 12:13:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20110105101307.GA14558@redhat.com> References: <20101216175516.6420.66081.stgit@s20.home> <20110104192739.1909.73162.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110104192739.1909.73162.stgit@s20.home> Subject: [Qemu-devel] Re: [RESEND PATCH 0/2] Fix rtl8139 migration with hotplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, quintela@redhat.com On Tue, Jan 04, 2011 at 12:37:37PM -0700, Alex Williamson wrote: > rtl8139 includes a cpu_register_io_memory() in it's vmstate. This > is problematic if the guest undergoes hotplug operations, which can > shift io indexes between migration source and target. Add an > interface to detect this condition and add a subsection, when > necessary, to ensure we migrate to a safe target. > > This resolves Juan's concerns about maintaining the migration ABI > and Michael's concerns wrt subsections. Acked by both. Please apply. > Thanks, > > Alex Applied, thanks! > --- > > Alex Williamson (2): > rtl8139: Use subsection to restrict migration after hotplug > qdev: Track runtime machine modifications > > > hw/qdev.c | 10 ++++++++++ > hw/qdev.h | 1 + > hw/rtl8139.c | 28 +++++++++++++++++++++++++++- > 3 files changed, 38 insertions(+), 1 deletions(-)