From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45527 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PaSnz-00033c-9J
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:49:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PaSnr-0007pu-IE
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:49:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PaSnr-0007pn-9z
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:49:23 -0500
Date: Wed, 5 Jan 2011 14:49:03 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110105124903.GA22115@redhat.com>
References: <1294224062-18745-1-git-send-email-Jes.Sorensen@redhat.com>
	<20110105123438.GA21883@redhat.com> <4D2465D3.1030609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2465D3.1030609@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of
	ssize_t
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org

On Wed, Jan 05, 2011 at 01:36:35PM +0100, Jes Sorensen wrote:
> On 01/05/11 13:34, Michael S. Tsirkin wrote:
> > On Wed, Jan 05, 2011 at 11:41:02AM +0100, Jes.Sorensen@redhat.com wrote:
> >> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >>
> >> strtosz() needs to return a 64 bit type even on 32 bit
> >> architectures. Otherwise qemu-img will fail to create disk
> >> images >= 2GB
> >>
> >> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > 
> > Nothing wrong with this patch, but should the function
> > be renamed to strtos64 then?
> 
> I don't think that adds any value to be honest. The problem with the old
> interface was that the return type differed depending on whether it was
> compiled on 32 vs 64 bit systems.
> 
> Cheers,
> Jes

Yes, but does not the name strtosz imply 'string to size'?
Further changing the name will help make sure there are no
users you forgot to update.

-- 
MST