From: Nathan Froyd <froydnj@codesourcery.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: use float32_is_any_nan()
Date: Wed, 5 Jan 2011 09:04:59 -0800 [thread overview]
Message-ID: <20110105170458.GD6247@codesourcery.com> (raw)
In-Reply-To: <1293970009-2028-1-git-send-email-aurelien@aurel32.net>
On Sun, Jan 02, 2011 at 01:06:49PM +0100, Aurelien Jarno wrote:
> Use the new function float32_is_any_nan() instead of
> float32_is_quiet_nan() || float32_is_signaling_nan().
>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>
> @@ -1938,7 +1938,7 @@ target_ulong helper_dlmzb (target_ulong high, target_ulong low, uint32_t update_
> /* If X is a NaN, store the corresponding QNaN into RESULT. Otherwise,
> * execute the following block. */
> #define DO_HANDLE_NAN(result, x) \
> - if (float32_is_quiet_nan(x) || float32_is_signaling_nan(x)) { \
> + if (float32_is_any_nan(x)) { \
> CPU_FloatU __f; \
> __f.f = x; \
> __f.l = __f.l | (1 << 22); /* Set QNaN bit. */ \
If you were looking for other cleanups, this could stand a
maybe_silence_nan.
-Nathan
prev parent reply other threads:[~2011-01-05 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 12:06 [Qemu-devel] [PATCH] target-ppc: use float32_is_any_nan() Aurelien Jarno
2011-01-05 16:59 ` [Qemu-devel] " Alexander Graf
2011-01-05 17:14 ` Peter Maydell
2011-01-05 17:19 ` Alexander Graf
2011-01-05 17:04 ` Nathan Froyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105170458.GD6247@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).